A little php help | WPDFD.com Forums

Maia said:

01/05/04, 005 02 2004 2004:%i:1073340120 17:02:00

I am very new to writing php (if "writing" is the correct word). I wanted to make a small include script for headers where I could change one page and see the effects across my site, but have the actual text for the header on the individual pages. So I threw this together. I'd like to know if there are serious bugs here, or if this is a unsafe/unstable/strange? way to do it. It works fine on my site, without any errors, but bad coding can do that sometimes. Here is the code:

pagetitles.php


function Skin_title($page_title) {
 $this->page_title = $page_title;
 
      print '
' . $page_title . '
';
}

?>

index.php

Thanks,
Maia

Suzanne said:

01/05/04, 005 44 2004 2004:%i:1073349840 19:44:00

Starting with OOP is pretty good, most people start with procedural!

It doesn't appear to have any security flaws, however you can always tuck your included files in a non-web-browsable directory (pagetitles.php) to make sure?

I would note that with your markup, however, it would be much more portable to have it as '

' . $page_title . '

' instead, and use CSS to style it. (or with

tags -- the table element isn't being used well in your example).

Maia said:

01/08/04, 008 01 2004 2004:%i:1073595661 16:01:01

Thanks. I have some more ideas now and hope to impliment your suggestions sometime soon. I've been spending way too much time over at Quirksmode investigating css & div options. Sad how things die...in some ways tables were rather nice.

Jdenny said:

02/14/04, 045 58 2004 2004:%i:1076813884 21:58:04

Over-complicated or what!

The simple answer is simmilar to using SSI (server-side-includes), but obviously with much more potential, (you can do stuff like you origional solution - but only do so when the complexity is needed to add value to your work).

PHP Includes:
in all of you pages put
$page_title = "....";
include('header.php');
?>

in header.php put